[lldb][test] DW_OP_piece-O3.c: Disable on Windows #117355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb @llvm/pr-subscribers-backend-aarch64 Author: Ilia Kuklin (kuilpd) Changes#117168 Full diff: https://github.com/llvm/llvm-project/pull/117355.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
index 77ea81f30395f0..50d13e446d539f 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
+++ b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
@@ -5,9 +5,10 @@
// DW_AT_type (0x00000032 "char[5]")
// DW_AT_location (DW_OP_piece 0x2, DW_OP_addrx 0x0, DW_OP_piece 0x1)
+// XFAIL: target=aarch64-pc-windows-{{.*}}
// RUN: %clang_host -O3 -gdwarf %s -o %t
// RUN: %lldb %t \
-// RUN: -o "b 25" \
+// RUN: -o "b 26" \
// RUN: -o "r" \
// RUN: -o "p/x array[2]" \
// RUN: -b | FileCheck %s
|
luporl
reviewed
Nov 22, 2024
| @@ -5,9 +5,10 @@ | |||
| // DW_AT_type (0x00000032 "char[5]") | |||
| // DW_AT_location (DW_OP_piece 0x2, DW_OP_addrx 0x0, DW_OP_piece 0x1) | |||
|
|
|||
| // XFAIL: target=aarch64-pc-windows-{{.*}} | |||
There was a problem hiding this comment.
It's better to just skip the test on windows:
// UNSUPPORTED: system-windows
At least on AArch64, debug info doesn't work with -O3 -gdwarf.
There was a problem hiding this comment.
Ah, thank you, good to know!
kuilpd
changed the title
luporl
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#117168